tests/integration/mtree_truncate_test.go (1)

106-110: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Log the failure of os.Remove during cleanup.

Although this is a best-effort cleanup, explicitly handling and logging potential errors from os.Remove aligns with the convention used elsewhere in the test (like MtreeTeardown) and ensures failures don't silently go unnoticed. Based on learnings, cleanup callbacks in integration tests should log expected failures with t.Logf rather than silently dropping them.

(Note: Ignoring the error from filepath.Glob is safe here since it only returns an error for malformed patterns, and the hardcoded pattern is valid.)

♻️ Proposed refactor

 		files, _ := filepath.Glob("*_diffs-*.json")
 		for _, f := range files {
-			os.Remove(f)
+			if err := os.Remove(f); err != nil {
+				t.Logf("Warning: failed to remove diff file %s: %v", f, err)
+			}
 		}

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tests/integration/mtree_truncate_test.go` around lines 106 - 110, Handle the
error returned by os.Remove in the cleanup loop and log any failure with t.Logf,
matching the existing MtreeTeardown cleanup convention while preserving
best-effort cleanup. Keep the filepath.Glob error handling unchanged.

Source: Learnings